arcayr/saphyr-serde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Quotes string starting with a dot

Browse source 
To understand why we want to do this, please refer to this issue on ktmpl repository (a way to have templates for kubernetes):
https://github.com/InQuicker/ktmpl/issues/15

The problem applies only to string used as keys, but given that the emitters right now doesn't differentiate the two cases for string, I think is better to do it also for values instead of introducing branching and/or flag variables (can't think of cleaner solution for now).
This commit is contained in:
Iazel 2017-05-06 19:06:10 +02:00 committed by GitHub
parent ed6ad8d6f0
commit d6e14acbe6
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
saphyr/src/emitter.rs
View file

@ -271,6 +271,7 @@ fn need_quotes(string: &str) -> bool {
|| string == "false" || string == "false"
|| string == "null" || string == "null"
|| string == "~" || string == "~"
|| string.starts_with('.')
|| string.parse::<i64>().is_ok() || string.parse::<i64>().is_ok()
|| string.parse::<f64>().is_ok() || string.parse::<f64>().is_ok()
} }
@ -374,6 +375,8 @@ products:
amount: 4 amount: 4
"*cookies": "*cookies":
amount: 4 amount: 4
".milk":
amount: 1
"2.4": real key "2.4": real key
"[1,2,3,4]": array key "[1,2,3,4]": array key
"true": bool key "true": bool key