From 5170d0374dc80f6dae0b60fc0db581e38efd42d3 Mon Sep 17 00:00:00 2001 From: Anton Kochkov Date: Wed, 27 May 2020 14:15:28 +0800 Subject: [PATCH] Rust 2018 transition --- saphyr/src/emitter.rs | 18 +++++++++--------- saphyr/src/lib.rs | 8 ++++---- saphyr/src/parser.rs | 2 +- saphyr/src/scanner.rs | 10 +++++----- saphyr/src/yaml.rs | 6 +++--- 5 files changed, 22 insertions(+), 22 deletions(-) diff --git a/saphyr/src/emitter.rs b/saphyr/src/emitter.rs index 872d1c8..d461001 100644 --- a/saphyr/src/emitter.rs +++ b/saphyr/src/emitter.rs @@ -1,7 +1,7 @@ use std::convert::From; use std::error::Error; use std::fmt::{self, Display}; -use yaml::{Hash, Yaml}; +use crate::yaml::{Hash, Yaml}; #[derive(Copy, Clone, Debug)] pub enum EmitError { @@ -17,7 +17,7 @@ impl Error for EmitError { } } - fn cause(&self) -> Option<&Error> { + fn cause(&self) -> Option<&dyn Error> { None } } @@ -38,7 +38,7 @@ impl From for EmitError { } pub struct YamlEmitter<'a> { - writer: &'a mut fmt::Write, + writer: &'a mut dyn fmt::Write, best_indent: usize, compact: bool, @@ -48,7 +48,7 @@ pub struct YamlEmitter<'a> { pub type EmitResult = Result<(), EmitError>; // from serialize::json -fn escape_str(wr: &mut fmt::Write, v: &str) -> Result<(), fmt::Error> { +fn escape_str(wr: &mut dyn fmt::Write, v: &str) -> Result<(), fmt::Error> { wr.write_str("\"")?; let mut start = 0; @@ -111,7 +111,7 @@ fn escape_str(wr: &mut fmt::Write, v: &str) -> Result<(), fmt::Error> { } impl<'a> YamlEmitter<'a> { - pub fn new(writer: &'a mut fmt::Write) -> YamlEmitter { + pub fn new(writer: &'a mut dyn fmt::Write) -> YamlEmitter { YamlEmitter { writer, best_indent: 2, @@ -316,12 +316,12 @@ fn need_quotes(string: &str) -> bool { | '\"' | '\'' | '\\' - | '\0'...'\x06' + | '\0'..='\x06' | '\t' | '\n' | '\r' - | '\x0e'...'\x1a' - | '\x1c'...'\x1f' => true, + | '\x0e'..='\x1a' + | '\x1c'..='\x1f' => true, _ => false, }) || [ @@ -344,7 +344,7 @@ fn need_quotes(string: &str) -> bool { #[cfg(test)] mod test { use super::*; - use YamlLoader; + use crate::YamlLoader; #[test] fn test_emit_simple() { diff --git a/saphyr/src/lib.rs b/saphyr/src/lib.rs index 40cff18..af1423c 100644 --- a/saphyr/src/lib.rs +++ b/saphyr/src/lib.rs @@ -52,10 +52,10 @@ pub mod scanner; pub mod yaml; // reexport key APIs -pub use emitter::{EmitError, YamlEmitter}; -pub use parser::Event; -pub use scanner::ScanError; -pub use yaml::{Yaml, YamlLoader}; +pub use crate::emitter::{EmitError, YamlEmitter}; +pub use crate::parser::Event; +pub use crate::scanner::ScanError; +pub use crate::yaml::{Yaml, YamlLoader}; #[cfg(test)] mod tests { diff --git a/saphyr/src/parser.rs b/saphyr/src/parser.rs index 22692ff..cf25fdd 100644 --- a/saphyr/src/parser.rs +++ b/saphyr/src/parser.rs @@ -1,4 +1,4 @@ -use scanner::*; +use crate::scanner::*; use std::collections::HashMap; #[derive(Clone, Copy, PartialEq, Debug, Eq)] diff --git a/saphyr/src/scanner.rs b/saphyr/src/scanner.rs index 6f4fa58..b2ce148 100644 --- a/saphyr/src/scanner.rs +++ b/saphyr/src/scanner.rs @@ -67,7 +67,7 @@ impl Error for ScanError { self.info.as_ref() } - fn cause(&self) -> Option<&Error> { + fn cause(&self) -> Option<&dyn Error> { None } } @@ -199,7 +199,7 @@ fn is_digit(c: char) -> bool { #[inline] fn is_alpha(c: char) -> bool { match c { - '0'...'9' | 'a'...'z' | 'A'...'Z' => true, + '0'..='9' | 'a'..='z' | 'A'..='Z' => true, '_' | '-' => true, _ => false, } @@ -211,9 +211,9 @@ fn is_hex(c: char) -> bool { #[inline] fn as_hex(c: char) -> u32 { match c { - '0'...'9' => (c as u32) - ('0' as u32), - 'a'...'f' => (c as u32) - ('a' as u32) + 10, - 'A'...'F' => (c as u32) - ('A' as u32) + 10, + '0'..='9' => (c as u32) - ('0' as u32), + 'a'..='f' => (c as u32) - ('a' as u32) + 10, + 'A'..='F' => (c as u32) - ('A' as u32) + 10, _ => unreachable!(), } } diff --git a/saphyr/src/yaml.rs b/saphyr/src/yaml.rs index fe112cc..f529f38 100644 --- a/saphyr/src/yaml.rs +++ b/saphyr/src/yaml.rs @@ -1,6 +1,6 @@ use linked_hash_map::LinkedHashMap; -use parser::*; -use scanner::{Marker, ScanError, TScalarStyle, TokenType}; +use crate::parser::*; +use crate::scanner::{Marker, ScanError, TScalarStyle, TokenType}; use std::collections::BTreeMap; use std::f64; use std::i64; @@ -368,7 +368,7 @@ impl Iterator for YamlIter { #[cfg(test)] mod test { use std::f64; - use yaml::*; + use crate::yaml::*; #[test] fn test_coerce() { let s = "---